Base controller has side effects

MetaMask · Mar 7, 2024 · f861204 · f861204
1 parent c18a9ff
commit f861204
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/constraints.pro b/constraints.pro
@@ -259,7 +259,8 @@ gen_enforced_field(WorkspaceCwd, 'exports', null) :-
 
 % Published packages must not have side effects.
 gen_enforced_field(WorkspaceCwd, 'sideEffects', false) :-
-  \+ workspace_field(WorkspaceCwd, 'private', true).
+  \+ workspace_field(WorkspaceCwd, 'private', true),
+  WorkspaceCwd \= 'packages/base-controller'.
 % Non-published packages must not specify side effects.
 gen_enforced_field(WorkspaceCwd, 'sideEffects', null) :-
   workspace_field(WorkspaceCwd, 'private', true).

diff --git a/packages/base-controller/package.json b/packages/base-controller/package.json
@@ -15,7 +15,6 @@
     "url": "https://github.com/MetaMask/core.git"
   },
   "license": "MIT",
-  "sideEffects": false,
   "exports": {
     ".": {
       "import": "./dist/index.mjs",