Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyring Consolidation: Patch core KeyringController on extension to expose inner EthKeyringController #1315

Closed
mikesposito opened this issue May 3, 2023 · 0 comments · Fixed by MetaMask/metamask-extension#19659
Closed

Keyring Consolidation: Patch core KeyringController on extension to expose inner EthKeyringController #1315

mikesposito opened this issue May 3, 2023 · 0 comments · Fixed by MetaMask/metamask-extension#19659
Assignees
@mikesposito
Labels
release-10.36.0 Issue or pull request that will be included in release 10.36.0 team-wallet-framework

Comments

@mikesposito
Copy link
Member

mikesposito commented May 3, 2023 •
edited
Loading

In order to address issues from epic #18758 in separate PRs we should expose the inner EthKeyringController from core KeyringController, in order to use it in the meantime.
@mikesposito mikesposito mentioned this issue Jun 19, 2023
Merged
8 tasks
@mikesposito mikesposito self-assigned this Jun 20, 2023
This was referenced Jun 22, 2023
Merged
Merged
This was referenced Jul 4, 2023
Merged
Merged
@mikesposito mikesposito mentioned this issue Jul 17, 2023
Merged
3 tasks
@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikesposito mikesposito

Labels
release-10.36.0 Issue or pull request that will be included in release 10.36.0 team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use @metamask/keyring-controller MetaMask/metamask-extension
2 participants
@mikesposito @metamaskbot