Fix normalize for empty strings
#315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikesposito
force-pushed
the
fix/normalize-for-empty-strings
branch
from
f1cabce to
39fd8b7
Compare
|
See also: #306 |
Gudahtt
added a commit
that referenced
this pull request
Jun 29, 2023
A test has been added to capture the behavior of the `normalize` function when a zero is passed in. This behavior changed recently in PR #315.
Gudahtt
added a commit
that referenced
this pull request
Jun 29, 2023
A test has been added to capture the behavior of the `normalize` function when a zero is passed in. This behavior changed recently in PR #315.
This was referenced Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
normalizefunction uses a logical NOT (!) to check if the input is nullish, but this causes to returnundefinedwhen an empty string is passed as input.As a fix, this PR uses the
isNullishfunction instead of the logical NOT.Changes
normalizefunction for empty stringsReferences