-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert TokensController from BaseControllerV1 to BaseControllerV2 #4075
Labels
Comments
29 tasks
desi
changed the title
(
Convert TokensController from BaseControllerV1 to BaseControllerV2
Mar 18, 2024
assets-controllers
) TokensController
Along with the main change of extending
|
|
3 tasks
cryptodev-2s
added a commit
that referenced
this issue
May 29, 2024
## Explanation The TokensController has been migrated to BaseControllerV2. As part of this migration, the deprecated config property has been removed and has been replaced with flatten properties on the controller constructor (`chainId`, `selectedAddress` and `provider`). PS: A migration is needed when using a new release of this controller. ## References * Fixes #4075 ## Changelog ### `@metamask/assets-controllers` #### Changed - **BREAKING:** Convert TokensController to `BaseControllerV2` - The constructor parameters have changed; rather than accepting a "config" parameter, it takes`selectedAddress` and `provider` parameters. - **BREAKING:** Convert Token object in TokenBalancesController to a `type` instead of `interface` and replace the `balanceError` property with `hasBalanceError` flag. ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Considering that converting TokenDetectionController to BaseController v2 took longer than expected due to unforeseen changes, we want to be more conscientious about converting TokensController.
Figure out all of the changes we would want to make in upgrading this controller, outline those changes here and create new tickets if appropriate.
The text was updated successfully, but these errors were encountered: