Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate PhishingController to BaseControllerV2 #1705

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Migrate PhishingController to BaseControllerV2 #1705

merged 5 commits into from
Sep 26, 2023

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Sep 22, 2023 •
edited
Loading

Explanation

This migrates the PhishingController to BaseControllerV2

Changelog

Added

  • Add maybeUpdateState and testOrigin actions

Changed

  • BREAKING: PhishingController now inherits from BaseControllerV2
  • BREAKING: PhishingControllernow expects a messenger option (and corresponding type PhishingControllerMessenger is now available)
  • BREAKING: The constructor takes a single argument, an options bag, instead of three arguments
  • BREAKING: The disabled configuration is no longer supported

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@GuillaumeRx GuillaumeRx force-pushed the gr/migrate-phishing-controller-v2 branch from 67f9d19 to 7adc61c Compare September 25, 2023 10:58
@GuillaumeRx GuillaumeRx marked this pull request as ready for review September 25, 2023 10:58
@GuillaumeRx GuillaumeRx requested a review from a team as a code owner September 25, 2023 10:58
Gudahtt
Gudahtt approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There are a few more changes to mention though:

Added

  • Add maybeUpdateState and testOrigin actions

Changed

  • BREAKING: The disabled configuration is no longer supported

@GuillaumeRx GuillaumeRx force-pushed the gr/migrate-phishing-controller-v2 branch from 7adc61c to 6fa215e Compare September 25, 2023 17:38
@GuillaumeRx GuillaumeRx force-pushed the gr/migrate-phishing-controller-v2 branch from 6fa215e to 5632131 Compare September 25, 2023 20:24
@GuillaumeRx GuillaumeRx force-pushed the gr/migrate-phishing-controller-v2 branch from 5632131 to b339160 Compare September 26, 2023 12:44
@GuillaumeRx GuillaumeRx merged commit 22786ef into main Sep 26, 2023
@GuillaumeRx GuillaumeRx deleted the gr/migrate-phishing-controller-v2 branch September 26, 2023 13:11
@mcmire mcmire mentioned this pull request Oct 11, 2023
Closed
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@GuillaumeRx @MajorLift
Migrate PhishingController to BaseControllerV2 (#1705)
0cffd19
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@GuillaumeRx @MajorLift
Migrate PhishingController to BaseControllerV2 (#1705)
d36d551
@mcmire mcmire mentioned this pull request Nov 22, 2023
Closed
@MajorLift MajorLift mentioned this pull request Dec 6, 2023
Open
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeRx @Gudahtt