Bump eslint to ^9.11.1 and migrate to flat config
#4727
Conversation
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
MajorLift
force-pushed
the
jongsun/preview/240924-eslint9
branch
2 times, most recently
from
bf0f6eb to
a680d66
Compare
- if an ignores key is used without any other keys in the configuration object, then the patterns act as global ignores. > https://eslint.org/docs/latest/use/configure/ignore#ignoring-files
MajorLift
force-pushed
the
jongsun/preview/240924-eslint9
branch
from
a680d66 to
792cf47
Compare
MajorLift
force-pushed
the
jongsun/preview/240924-eslint9
branch
from
235f317 to
86311e7
Compare
MajorLift
changed the title
eslint to ^9.11.1 and migrate to flat config
|
Updated to latest stable release of |
|
@SocketSecurity ignore npm/@nolyfill/[email protected] This is coming from |
We recently released new versions of our ESLint packages to rely on ESLint 9. This PR bumps all of the ESLint-related packages in this repo to match, and migrates the current ESLint config into the new flat format. It also upgrades Prettier to v3. --------- Co-authored-by: Elliot Winkler <[email protected]>
## Description This PR implements a major update to our ESLint configuration and related dependencies, migrating to ESLint 9.0.0 and adopting the new flat configuration format. This change aligns with the recent updates in our core repository and addresses multiple dependency updates that were pending through Dependabot. Key improvements: 1. Migration to ESLint 9's flat configuration format using `eslint.config.mjs` 2. Removal of legacy `.eslintrc.js` files across packages 3. Consolidation of ESLint configurations 4. Update of all ESLint-related dependencies to their latest versions This PR resolves [issue #285](#285) and consolidates the following Dependabot PRs: - [#280](#280) - @metamask/eslint-config-typescript upgrade - [#279](#279) - @metamask/eslint-config-jest upgrade - [#275](#275) - @metamask/eslint-config-nodejs upgrade - [#274](#274) - @metamask/eslint-config upgrade ## Related issues Fixes: #285 ## Manual testing steps 1. Pull down the branch 2. Run `yarn` to update dependencies 3. Run `yarn lint` to verify ESLint runs successfully 4. Run `yarn changelog:validate` to verify auto changelog runs successfully 5. Verify that ESLint rules are being properly enforced in your editor 6. Test across all packages to ensure linting works as expected ## Screenshots/Recordings https://github.com/user-attachments/assets/95877c2b-c0da-4eae-9f34-a75626bec9da ## Pre-merge author checklist - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) - [x] I've completed the PR template - [x] I've included tests (linting configuration tests) - [x] I've documented configuration changes - [x] I've applied appropriate labels ## References - [Core Repository Implementation](MetaMask/core#4727) - [ESLint 9.0.0 Migration Guide](https://eslint.org/docs/latest/use/migrate-to-9.0.0) - [ESLint Configuration Migration Guide](https://eslint.org/docs/latest/use/configure/migration-guide) ## Pre-merge reviewer checklist - [ ] I've manually tested the PR - [ ] I confirm that this PR addresses all acceptance criteria - [ ] I've verified that linting works correctly across all packages
Explanation
We recently released new versions of our ESLint packages to rely on ESLint 9. This PR bumps all of the ESLint-related packages in this repo to match, and migrates the current ESLint config into the new flat format. It also upgrades Prettier to v3.
References
Closes #4745.
Changelog
(N/A; developer-only change)
Checklist