Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v10.1.0 #488

Merged
merged 5 commits into from
Jun 7, 2021
Merged

v10.1.0 #488

merged 5 commits into from
Jun 7, 2021

Conversation

estebanmino
Copy link
Contributor

@estebanmino estebanmino commented Jun 7, 2021 •
edited
Loading

[10.1.0] - 2021-06-7

Added

  • Export BaseControllerV2 Json type (#482)

Changed

  • Improve collectible detection by account (#487)
  • Upgrade ethereumjs util (#466)

Fixed

  • Skip token detection for tokens that are already tracked (#480)

@estebanmino estebanmino requested a review from a team as a code owner June 7, 2021 15:19
Gudahtt
Gudahtt reviewed Jun 7, 2021
View reviewed changes
CHANGELOG.md Outdated

### Changed
- Improve collectible detection by account ([#487](https://github.com/MetaMask/controllers/pull/487))
- Mapping token address strings instead of Token objects while checking for new tokens ([#480](https://github.com/MetaMask/controllers/pull/480))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was more of a bug fix, or at least that was my understanding. I would put this under Fixed, with the description "Skip token detection for tokens that are already tracked", or something like that. That was the bug - that we're detecting all tokens, even those already on the user's list.

Gudahtt
Gudahtt previously approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a suggestion for the changelog, but we can adjust that in a follow-up if you're in a rush to release this.

@estebanmino
Copy link
Contributor Author

@Gudahtt changed tha changelog as you suggested! 👌

Gudahtt
Gudahtt approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@estebanmino estebanmino merged commit 31345f9 into main Jun 7, 2021
@estebanmino estebanmino deleted the v10.1.0 branch June 7, 2021 15:47
@Gudahtt
Copy link
Member

Gudahtt commented Jun 7, 2021

A new version of the package @metamask/controllers (10.1.0) was published at 2021-06-07T16:08:13.739Z from
[redacted]. The shasum of this package was ec0a3751fa658966e9818038784ab6b555c95382.

MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@estebanmino @MajorLift
v10.1.0 (#488)
dc1c5d0 
* bump

* changelog

* date

* typo

* fixed
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@estebanmino @MajorLift
v10.1.0 (#488)
a432a8f 
* bump

* changelog

* date

* typo

* fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estebanmino @Gudahtt