@metamask/[email protected] #767
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
changed the title
rekmarks
force-pushed
the
@metamask/eth-sig-util
branch
from
f27ee2b to
27cef8e
Compare
Gudahtt
reviewed
Apr 7, 2022
| case SignTypedDataVersion.V4: | ||
| return signTypedData_v4(privateKeyBuffer, { | ||
| data: JSON.parse(messageParams.data as string), |
There was a problem hiding this comment.
These JSON.parse calls were removed, but we still need this to be JSON data rather than a string
Gudahtt
changed the title
|
Some of the unit tests are failing here because of a mistake made in the typed message schema in |
|
The schema mistake has been fixed and published as [email protected] |
|
Is this something we need to get into the next release? I'm assuming no since this is still in draft, but just wanted to check. |
|
This was done in #914 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
[email protected]with@metamask/[email protected].This prevents some messages that appear to have been previously accepted from being signed, so this ought to be a breaking change.