AnnouncementController migration to BaseControllerV2 #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vthomas13
commented
Nov 15, 2022
vthomas13
changed the title
mcmire
reviewed
Nov 21, 2022
There was a problem hiding this comment.
Hey @vthomas13! Congrats on your first PR 🎉 I had a few suggestions below but this PR looks very nice!
Gudahtt
reviewed
Nov 29, 2022
|
|
vthomas13
force-pushed
the
announcementV2-migration
branch
from
1af2383 to
fdcba9e
Compare
mcmire
reviewed
Dec 2, 2022
There was a problem hiding this comment.
Hey @vthomas13 sorry this has been in review so long 😬 I'll make sure I monitor this more closely so we can get this in.
vthomas13
force-pushed
the
announcementV2-migration
branch
2 times, most recently
from
ef9a2f7 to
3f68392
Compare
vthomas13
force-pushed
the
announcementV2-migration
branch
from
3f68392 to
c3c9c37
Compare
Gudahtt
reviewed
Dec 6, 2022
Gudahtt
approved these changes
Dec 8, 2022
Merged
Gudahtt
added a commit
that referenced
this pull request
Dec 20, 2022
Changelogs: # `announcement-controller` ## [2.0.0] ### Changed - **BREAKING:** Migrate to BaseControllerV2 ([#959](#959)) - The announcement controller now extends `BaseControllerV2` rather than `BaseController`, which includes the following changes: - The constructor now accepts a single "args" object rather than positional parameters. - A restricted controller messenger instance must be passed into the constructor. - The controller configuration has been replaced by an `allAnnouncements` constructor parameter. - The following properties previously inherited from `BaseController` are no longer present: - `defaultConfig` - `defaultState` - `disabled` - `config` - `state` - The following methods previously inherited from `BaseController` are no longer present: - `configure` - `notify` - `subscribe` - `unsubscribe` - `update` - The `name` property is now readonly. # `assets-controllers` ## [3.0.1] ### Changed - Export `isTokenDetectionSupportedForNetwork` function ([#1034](#1034)) - Update `@metamask/contract-metadata` from 1.35.0 to 2.1.0 ([#1013](#1013)) ### Fixed - Fix token controller state updates ([#1015](#1015)) - Attempts to empty the list of "added", "ignored", or "detected" tokens were not saved in state correctly, resulting in that operation being undone after switching account or network.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
AnnouncementController migration to BaseControllerV2 Resolves #945
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Changelogs: # `announcement-controller` ## [2.0.0] ### Changed - **BREAKING:** Migrate to BaseControllerV2 ([#959](#959)) - The announcement controller now extends `BaseControllerV2` rather than `BaseController`, which includes the following changes: - The constructor now accepts a single "args" object rather than positional parameters. - A restricted controller messenger instance must be passed into the constructor. - The controller configuration has been replaced by an `allAnnouncements` constructor parameter. - The following properties previously inherited from `BaseController` are no longer present: - `defaultConfig` - `defaultState` - `disabled` - `config` - `state` - The following methods previously inherited from `BaseController` are no longer present: - `configure` - `notify` - `subscribe` - `unsubscribe` - `update` - The `name` property is now readonly. # `assets-controllers` ## [3.0.1] ### Changed - Export `isTokenDetectionSupportedForNetwork` function ([#1034](#1034)) - Update `@metamask/contract-metadata` from 1.35.0 to 2.1.0 ([#1013](#1013)) ### Fixed - Fix token controller state updates ([#1015](#1015)) - Attempts to empty the list of "added", "ignored", or "detected" tokens were not saved in state correctly, resulting in that operation being undone after switching account or network.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
AnnouncementController migration to BaseControllerV2 Resolves #945
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Changelogs: # `announcement-controller` ## [2.0.0] ### Changed - **BREAKING:** Migrate to BaseControllerV2 ([#959](#959)) - The announcement controller now extends `BaseControllerV2` rather than `BaseController`, which includes the following changes: - The constructor now accepts a single "args" object rather than positional parameters. - A restricted controller messenger instance must be passed into the constructor. - The controller configuration has been replaced by an `allAnnouncements` constructor parameter. - The following properties previously inherited from `BaseController` are no longer present: - `defaultConfig` - `defaultState` - `disabled` - `config` - `state` - The following methods previously inherited from `BaseController` are no longer present: - `configure` - `notify` - `subscribe` - `unsubscribe` - `update` - The `name` property is now readonly. # `assets-controllers` ## [3.0.1] ### Changed - Export `isTokenDetectionSupportedForNetwork` function ([#1034](#1034)) - Update `@metamask/contract-metadata` from 1.35.0 to 2.1.0 ([#1013](#1013)) ### Fixed - Fix token controller state updates ([#1015](#1015)) - Attempts to empty the list of "added", "ignored", or "detected" tokens were not saved in state correctly, resulting in that operation being undone after switching account or network.
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AnnouncementController migration to BaseControllerV2
Resolves #945