This repository has been archived by the owner on Nov 26, 2024. It is now read-only.
generated from MetaMask/metamask-module-template
-
Notifications
You must be signed in to change notification settings - Fork 16
chore: adding initial json generated from figma variables #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgewrmarshall
added
the
team-design-system
All issues relating to design system
label
Apr 25, 2024
georgewrmarshall
requested review from
brianacnguyen,
garrettbear and
Akatori-Design
April 25, 2024 22:41
garrettbear
reviewed
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh this is going to be a fun merge conflict for me... 🙃
garrettbear
previously approved these changes
Apr 25, 2024
brianacnguyen
previously approved these changes
Apr 25, 2024
georgewrmarshall
dismissed stale reviews from brianacnguyen and garrettbear
via
April 26, 2024 19:34
9428072
brianacnguyen
approved these changes
Apr 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR focuses on updating the Storybook documentation for our Figma brand color, light theme, and dark theme. The updates aim to ensure that our Storybook documentation accurately reflects the latest design tokens and color schemes as defined in Figma.
Related issues
Fixes: #656
Manual testing steps
To verify the updates to the Storybook documentation:
yarn storybook
to launch Storybook.Screenshots/Recordings
Before
beforeo720.mov
After
after720.mov
Pre-merge author checklist
Pre-merge reviewer checklist
This PR is a crucial step towards maintaining a cohesive and accessible design system by ensuring our Storybook documentation remains a reliable and up-to-date resource for developers and designers alike.