Skip to content
This repository has been archived by the owner on Nov 26, 2024. It is now read-only.

chore: adding initial json generated from figma variables #673

Merged
merged 5 commits into from
Apr 26, 2024

Conversation

georgewrmarshall
Copy link
Collaborator

@georgewrmarshall georgewrmarshall commented Apr 25, 2024

Description

This PR focuses on updating the Storybook documentation for our Figma brand color, light theme, and dark theme. The updates aim to ensure that our Storybook documentation accurately reflects the latest design tokens and color schemes as defined in Figma.

This will make the CSS and JS tokens unaligned for the time being. We will update those in subsequent PRs with a focus on deprecating the old values instead of removing them

Related issues

Fixes: #656

Manual testing steps

To verify the updates to the Storybook documentation:

  1. Go to the storybook build of this PR or run yarn storybook to launch Storybook.
  2. Navigate to the sections detailing the Figma brand color, light theme, and dark theme documentation.
  3. Review the documentation for accuracy, completeness, and alignment with the current design tokens and color schemes in Figma.
  4. Ensure that the documentation provides clear guidance on applying these design tokens and themes within projects.

Screenshots/Recordings

Before

beforeo720.mov

After

after720.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues.
  • I've included manual testing steps.
  • I've included screenshots/recordings if applicable.
  • I’ve included tests if applicable.
  • I’ve documented my code using JSDoc format if applicable.
  • I’ve applied the right labels on the PR.
  • I’ve properly set the pull request status to "ready for review".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g., pull and build branch, run Storybook, review the updated documentation).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as screenshots or recordings.

This PR is a crucial step towards maintaining a cohesive and accessible design system by ensuring our Storybook documentation remains a reliable and up-to-date resource for developers and designers alike.

@metamaskbot
Copy link
Collaborator

Builds ready [e7fc644]

Storybook: Storybook

@georgewrmarshall georgewrmarshall self-assigned this Apr 25, 2024
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system label Apr 25, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [b606e70]

Storybook: Storybook

@georgewrmarshall georgewrmarshall marked this pull request as ready for review April 25, 2024 22:49
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner April 25, 2024 22:49
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is going to be a fun merge conflict for me... 🙃

garrettbear
garrettbear previously approved these changes Apr 25, 2024
brianacnguyen
brianacnguyen previously approved these changes Apr 25, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [9428072]

Storybook: Storybook

@metamaskbot
Copy link
Collaborator

Builds ready [df18a2f]

Storybook: Storybook

@georgewrmarshall georgewrmarshall merged commit 825eba4 into main Apr 26, 2024
19 checks passed
@georgewrmarshall georgewrmarshall deleted the fix/656/json-docs branch April 26, 2024 21:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-design-system All issues relating to design system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update JSON to Reflect Brand Evolution Updates
4 participants