Migrate to monorepo #140
Merged
Migrate to monorepo #140
+4,101
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
reviewed
Mar 30, 2021
Gudahtt
reviewed
Mar 30, 2021
Closed
Gudahtt
reviewed
Mar 30, 2021
Gudahtt
reviewed
Mar 30, 2021
Gudahtt
reviewed
Mar 30, 2021
Gudahtt
reviewed
Mar 30, 2021
| "private": true, | ||
| "workspaces": [ | ||
| "packages/base" | ||
| ] | ||
| } |
There was a problem hiding this comment.
Should lerna be here as a dev dependency? 🤔
There was a problem hiding this comment.
Hm, I think lerna recommends that you install it globally. I can either add it as a dev dep or add a note in the readme?
There was a problem hiding this comment.
Apparently not. From their README:
Let's start by installing Lerna as a dev dependency of your project with npm.
Gudahtt
reviewed
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In service of #104, this PR migrates this repo to a monorepo structure. The goal with this PR is to support splitting the existing config package into multiple packages. CI scripts have been altered to support the existence of multiple packages, but are otherwise unchanged.
After this is merged, numerous steps remain, including splitting the various configs into their own packages, migrating to GitHub Actions, and setting up automatic releases.