Bump min Node to 16, and use LTS Node for dev #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**This change is breaking.** We could bump this monorepo to Node 18, but since these packages are heavily depended upon, we don't need to do that yet until we've confirmed all other projects are using 18. Using the LTS version of Node puts us on a more modern version for development (and also happens to fix the `.nvmrc` file so `asdf` can read it).
legobeat
reviewed
Oct 31, 2023
mcmire
changed the title
|
Updated to bump to Node 18 instead of 16. |
Do you think we could hold off on that part for now? There are enough packages depending on these packages behind on both node.engines and eslint configuration. Would prefer to have those numbers improved to reduce potentially troublesome upgrades and need of backports. WDYT? |
|
Sure, no problem. |
legobeat
previously approved these changes
Nov 30, 2023
|
Took the liberty of also updating ci to run on node v20 instead of v14 and v19 here. |
legobeat
previously approved these changes
Nov 30, 2023
legobeat
force-pushed
the
bump-node-to-16
branch
from
e4f55f1 to
d94f810
Compare
legobeat
approved these changes
Nov 30, 2023
Mrtenz
approved these changes
Nov 30, 2023
mcmire
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is breaking.
Using the LTS version of Node puts us on a more modern version for development (and also happens to fix the
.nvmrcfile so tools likeasdfcan read it, although that's a nice-to-have).