Migrate tests from tape to Jest #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The unit tests have been migrated from tape to Jest. The standard Jest config from the MetaMask module template has been used. We're using `ts-jest` to compile the tests and run them all at once, so we don't need a build step for the tests now either. The `build` command is now run separately on CI. The tape tests didn't break the tests into sections, which is commonly done for our Jest tests. So `describe` blocks haven't yet been used. I will be adding `describe` sections in later PRs though, as the tests are made more comprehensive. The tests were left mostly functionally equivalent. Some included minor changes, like checking the length of a property rather than just whether it's truthy, or checking the error message, to confirm with our Jest lint rules.
Gudahtt
force-pushed
the
migrate-tests-to-jest
branch
from
68b6033 to
c863ca6
Compare
Merged
shanejonas
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit tests have been migrated from tape to Jest. The standard Jest config from the MetaMask module template has been used.
We're using
ts-jestto compile the tests and run them all at once, so we don't need a build step for the tests now either. Thebuildcommand is now run separately on CI.The tape tests didn't break the tests into sections, which is commonly done for our Jest tests. So
describeblocks haven't yet been used. I will be addingdescribesections in later PRs though, as the tests are made more comprehensive.The tests were left mostly functionally equivalent. Some included minor changes, like checking the length of a property rather than just whether it's truthy, or checking the error message, to confirm with our Jest lint rules.