Rename signTypedData-related types.
#218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type `EIP712TypedData` has been renamed to `TypedDataV1Field` so that it does not get confused for a valid `signTypedData` message or field. This type is only used for `V1` of `signTypedData`, which was based on an early draft version of EIP-712 and doesn't reflect the state of that EIP today at all. The type `Version` has been renamed to `SignTypedDataVersion`. This ensures it doesn't get confused for an encryption version, for example. It's directly exported from this package, so it might not be clear at first that it's related to `signTypedData`.
Gudahtt
force-pushed
the
rename-sign-typed-data-related-types
branch
from
bf7f13d to
ab7ccc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type
EIP712TypedDatahas been renamed toTypedDataV1Fieldso that it does not get confused for a validsignTypedDatamessage or field. This type is only used forV1ofsignTypedData, which was based on an early draft version of EIP-712 and doesn't reflect the state of that EIP today at all.The type
Versionhas been renamed toSignTypedDataVersion. This ensures it doesn't get confused for an encryption version, for example. It's directly exported from this package, so it might not be clear at first that it's related tosignTypedData.