Fix lint rules for tests #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends upon #243 |
Gudahtt
commented
Apr 20, 2022
| extends: ['@metamask/eslint-config-jest'], | ||
| }, | ||
| ], | ||
| plugins: ['jsdoc'], |
There was a problem hiding this comment.
This plugin is already added in our general shared config, so this was redundant.
The lint configuration for tests was wrong (the file glob had the wrong file extension), so none of the test lint rules or globals were being set correctly. This has been fixed, and all rule violations have been fixed. There were a number of workarounds used in the tests for the globals `expect` and `it` not being recognized by the linter. These workarounds have now been removed as well, since globals are now correctly set.
Gudahtt
force-pushed
the
fix-test-lint-rules
branch
from
e601a71 to
a3f0433
Compare
mcmire
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lint configuration for tests was wrong (the file glob had the wrong file extension), so none of the test lint rules or globals were being set correctly. This has been fixed, and all rule violations have been fixed.
There were a number of workarounds used in the tests for the globals
expectanditnot being recognized by the linter. These workarounds have now been removed as well, since globals are now correctly set.