Break out domainHash generation #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danfinlay
force-pushed
the
break-up-smaller
branch
from
2008708 to
16586cc
Compare
legobeat
approved these changes
Mar 17, 2023
|
If we could add a test for this new function that would be great. Maybe in a new PR? :) |
|
The good news is that it has 100% code coverage, since it is already part of every other 712 method. I will see about writing a test, but I’ve been stretched a bit thin. |
|
@danfinlay Oh sure. No problem then! Being covered by other tests is good enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows more easily debugging at least that one component of the 712 signature.