Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Remove outdated example link #313

Merged
merged 1 commit into from
May 1, 2023
Merged

docs: Remove outdated example link #313

merged 1 commit into from
May 1, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Apr 29, 2023 •
edited
Loading

See open issues in repo.

Before being linked as example, it should:

  • Work out of the box on Nodejs v18, v20
  • Use @metamask/eth-sig-util instead of deprecated eth-sig-util
  • Update or replace other deprecated dependencies (webpack; other ethereum-related libraries)

@legobeat legobeat marked this pull request as ready for review April 29, 2023 00:04
@legobeat legobeat requested a review from a team as a code owner April 29, 2023 00:04
@legobeat legobeat requested review from naugtur and kumavis April 30, 2023 01:15
@legobeat legobeat merged commit 34ecf65 into MetaMask:main May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumavis kumavis kumavis approved these changes

@naugtur naugtur Awaiting requested review from naugtur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @kumavis