Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devDeps: [email protected]>^3.12.0 #10

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

legobeat
Copy link

@legobeat legobeat commented Nov 7, 2023

Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
webpack 2.1.0-beta.15...3.12.0 None +48/-31 6.68 MB sokra

Copy link

socket-security bot commented Nov 7, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: [email protected], [email protected], [email protected], [email protected], [email protected]

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat legobeat marked this pull request as ready for review November 7, 2023 05:16
@legobeat legobeat mentioned this pull request Nov 7, 2023
1 task
@legobeat

This comment was marked as resolved.

@legobeat

This comment was marked as resolved.

This was referenced Nov 7, 2023
@@ -52,7 +53,6 @@ if (env === 'production') {
screw_ie8: false,
},
}));
config.plugins.push(new webpack.optimize.DedupePlugin());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this enabled by default now?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@legobeat legobeat requested review from Mrtenz, FrederikBolding and MajorLift and removed request for Mrtenz November 7, 2023 11:11
@legobeat legobeat requested a review from a team November 14, 2023 11:20
Copy link

@naugtur naugtur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is supposed to be actively maintained it'd be nice to go up to webpack5 and it shouldn't be that big of a deal, but hey, this is a great improvement anyway.

@legobeat legobeat merged commit 588b5dc into MetaMask:main Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants