Add extended key property to SLIP10Node
#196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| index: 0, | ||
| }); | ||
|
|
||
| if (path.ours.tuple.length === 0) { |
There was a problem hiding this comment.
What is this meant to account for?
There was a problem hiding this comment.
We call derive below, which is not valid for an empty array.
There was a problem hiding this comment.
Ah, I had to remind myself of how the fixtures are structured
FrederikBolding
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an
extendedKeyproperty to SLIP-10 nodes, which returns the BIP-32 serialised extended key. This only works forsecp256k1nodes, as other standards don't specify a standard for serialisation, and the length of the keys is different across curves.I've also updated
SLIP10Node.fromExtendedKeyto accept a serialised extended key, instead of an options object.