Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provides missing util.js when used as dependency #54

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Jun 8, 2021

When this was refactored for hackability (#43), we moved to using a util.js file for some of the parsing. This wasn't added to the package.json's files array before publishing 3.0.0 today (#52) so this module becomes problematic when using as a dependency.

I've globally installed npm-previewpkg on my machine to preview files exported from a package to prevent this from happening again.

@darkwing darkwing requested a review from Gudahtt June 8, 2021 16:57
@darkwing darkwing requested a review from a team as a code owner June 8, 2021 16:57
package.json Outdated Show resolved Hide resolved
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@darkwing darkwing merged commit c59243b into main Jun 8, 2021
@darkwing darkwing deleted the missing-util branch June 8, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants