Hide links to etherscan when no block explorer is specified for a cus…

…tom network (#10455)

Conditionally render view on Etherscan text if it's a custom network

Fixes: #5631

app/scripts/platforms/extension.js

@@ -196,7 +196,9 @@ export default class ExtensionPlatform {
     const nonce = parseInt(txMeta.txParams.nonce, 16);
 
     const title = 'Confirmed transaction';
-    const message = `Transaction ${nonce} confirmed! View on Etherscan`;
+    const message = `Transaction ${nonce} confirmed! ${
+      url.length ? 'View on Etherscan' : ''
+    }`;
     this._showNotification(title, message, url);
   }
 

package.json

@@ -81,7 +81,7 @@
     "@metamask/controllers": "^5.1.0",
     "@metamask/eth-ledger-bridge-keyring": "^0.2.6",
     "@metamask/eth-token-tracker": "^3.0.1",
-    "@metamask/etherscan-link": "^1.4.0",
+    "@metamask/etherscan-link": "^1.4.1",
     "@metamask/inpage-provider": "^8.0.4",
     "@metamask/jazzicon": "^2.0.0",
     "@metamask/logo": "^2.5.0",

yarn.lock

@@ -2093,10 +2093,10 @@
     human-standard-token-abi "^1.0.2"
     safe-event-emitter "^1.0.1"
 
-"@metamask/etherscan-link@^1.4.0":
-  version "1.4.0"
-  resolved "https://registry.yarnpkg.com/@metamask/etherscan-link/-/etherscan-link-1.4.0.tgz#4631e9beec17de26b35b3ccd643ede2bae8ed811"
-  integrity sha512-4Bi72Y8/FQZbfTARyv+oWKGuECzdQ37cQKt88Eu5JPDrHAcRDZt4Bt7bWC9phUBrphAr1qbCKh9S90X9hW0pZg==
+"@metamask/etherscan-link@^1.4.1":
+  version "1.4.1"
+  resolved "https://registry.yarnpkg.com/@metamask/etherscan-link/-/etherscan-link-1.4.1.tgz#44377c5c9be2c02ef26aff5da74bd839e50c09f9"
+  integrity sha512-hs8Qi62+6BZN9J7dknnoJR4DStEP6PzWEwRt+ScEVM4CuBVo08mqY0HXRny52A6FjBQrSnBgA5gvMbBOMqDavg==
 
 "@metamask/forwarder@^1.1.0":
   version "1.1.0"