Fix font sizes, colors. Include data tab for send-eth transaction con…

…firmations that have data
MetaMask · Jul 12, 2018 · 6701771 · 6701771
1 parent 92fc87a
commit 6701771
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 4 deletions.
diff --git a/...m-page-container/confirm-page-container-content/confirm-page-container-warning/index.scss b/...m-page-container/confirm-page-container-content/confirm-page-container-warning/index.scss
@@ -13,6 +13,6 @@
 
   &__warning {
     font-size: .75rem;
-    color: $oslo-gray;
+    color: #5f5922;
   }
 }
diff --git a/ui/app/components/network-display/index.scss b/ui/app/components/network-display/index.scss
@@ -26,7 +26,7 @@
   }
 
   &__name {
-    font-size: .875rem;
+    font-size: .75rem;
     padding-left: 5px;
   }
 

diff --git a/ui/app/components/pages/confirm-send-ether/confirm-send-ether.component.js b/ui/app/components/pages/confirm-send-ether/confirm-send-ether.component.js
@@ -11,6 +11,7 @@ export default class ConfirmSendEther extends Component {
   static propTypes = {
     editTransaction: PropTypes.func,
     history: PropTypes.object,
+    txParams: PropTypes.object,
   }
 
   handleEdit ({ txData }) {
@@ -19,11 +20,18 @@ export default class ConfirmSendEther extends Component {
     history.push(SEND_ROUTE)
   }
 
+  shouldHideData () {
+    const { txParams = {} } = this.props
+    return !txParams.data
+  }
+
   render () {
+    const hideData = this.shouldHideData()
+
     return (
       <ConfirmTransactionBase
         action={this.context.t('confirm')}
-        hideData
+        hideData={hideData}
         onEdit={confirmTransactionData => this.handleEdit(confirmTransactionData)}
       />
     )

diff --git a/ui/app/components/pages/confirm-send-ether/confirm-send-ether.container.js b/ui/app/components/pages/confirm-send-ether/confirm-send-ether.container.js
@@ -5,6 +5,14 @@ import { updateSend } from '../../../actions'
 import { clearConfirmTransaction } from '../../../ducks/confirm-transaction.duck'
 import ConfirmSendEther from './confirm-send-ether.component'
 
+const mapStateToProps = state => {
+  const { confirmTransaction: { txData: { txParams } = {} } } = state
+
+  return {
+    txParams,
+  }
+}
+
 const mapDispatchToProps = dispatch => {
   return {
     editTransaction: txData => {
@@ -33,5 +41,5 @@ const mapDispatchToProps = dispatch => {
 
 export default compose(
   withRouter,
-  connect(null, mapDispatchToProps)
+  connect(mapStateToProps, mapDispatchToProps)
 )(ConfirmSendEther)