Skip to content

Commit

Permalink
feat: enable account syncing in production (#28596)
Browse files Browse the repository at this point in the history
## **Description**

This PR enables account syncing in production

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28596?quickstart=1)

## **Related issues**

Fixes: #28438 

## **Manual testing steps**

1. Onboard with your SRP
2. Add accounts, rename accounts
3. Uninstall the extension
4. Reinstall and onboard with the previous SRP
5. Verify that your added & renamed accounts are there

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
mathieuartu authored Nov 26, 2024
1 parent ad20b71 commit fd3ac16
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions app/scripts/metamask-controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ import {
NotificationServicesPushController,
NotificationServicesController,
} from '@metamask/notification-services-controller';
import { isProduction } from '../../shared/modules/environment';
import {
methodsRequiringNetworkSwitch,
methodsThatCanSwitchNetworkWithoutApproval,
Expand Down Expand Up @@ -1609,7 +1608,7 @@ export default class MetamaskController extends EventEmitter {
},
},
env: {
isAccountSyncingEnabled: !isProduction() && isManifestV3,
isAccountSyncingEnabled: isManifestV3,
},
messenger: this.controllerMessenger.getRestricted({
name: 'UserStorageController',
Expand Down

0 comments on commit fd3ac16

Please sign in to comment.