You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
in #13420 and #13423 it will need to be known if the transaction in question is dealing in the base asset for the network. This is easy to determine by examining txParams, and the code for doing so exists in the transaction controller as _determineTransactionType. If the result of that method is SIMPLE_SEND then we know we are dealing with the base asset.
Requirements/Suggested Implementation details
Extract the _determineTransactionType code to a helper method that can be used in either the IncomingTransactionController or TransactionController. Do not put this in shared as I believe it shouldn't be used on frontend.
The new function takes a txMeta object as input.
Function will check if the type parameter is already set, if it is it'll check if its a SIMPLE_SEND and return boolean based on that
If not it'll call the new helper method with txMeta.txParams to get the type prior to checking it against SIMPLE_SEND
The text was updated successfully, but these errors were encountered:
Description
in #13420 and #13423 it will need to be known if the transaction in question is dealing in the base asset for the network. This is easy to determine by examining
txParams
, and the code for doing so exists in the transaction controller as_determineTransactionType
. If the result of that method is SIMPLE_SEND then we know we are dealing with the base asset.Requirements/Suggested Implementation details
The text was updated successfully, but these errors were encountered: