Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_base_asset property to all transaction events in transaction funnel #13423

Closed
brad-decker opened this issue Jan 27, 2022 · 0 comments · Fixed by #13858
Closed

Add is_base_asset property to all transaction events in transaction funnel #13423

brad-decker opened this issue Jan 27, 2022 · 0 comments · Fixed by #13858

Comments

@brad-decker
Copy link
Contributor

Description

Product and business leaders would like to get a sense of how often MetaMask users send transactions of the base asset for the network. Essentially this means tracking any received Ether, BNB, etc but not ERC-20, ERC-721, etc. To do this we will need to modify the events in the TransactionController such that a new property is added to the event called is_base_asset

Requirements

  1. Modify the buildEventFragmentProperties method in the TransactionController to use the method created in Create utility method for determining if a transaction is sending base asset for current network #13422 to determine if it is a simple send.
  2. if the transaction is a simple send, set is_base_asset to true (default to false).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants