Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewUI: Indicate loading when confirmation screen is starting up #4195

Closed
danfinlay opened this issue May 5, 2018 · 3 comments
Closed

NewUI: Indicate loading when confirmation screen is starting up #4195

danfinlay opened this issue May 5, 2018 · 3 comments
Labels
area-UI Relating to the user interface. type-bug

Comments

@danfinlay
Copy link
Contributor

On stage at EdCon, the New UI confirmation windows took a painful 5 seconds or so to pop up during a live demo.

We should at the very least indicate why it's taking so long (old UI says "estimating gas cost"), and also investigate how we can make it load faster, if it's something we can control.

I wonder if #2991 would improve this performance.

@danfinlay danfinlay added type-bug area-UI Relating to the user interface. labels May 5, 2018
@danfinlay danfinlay added this to the Sprint 05 milestone May 5, 2018
@bdresser
Copy link
Contributor

bdresser commented Jun 4, 2018

i weirdly sometimes see a spinner and label that says "generating transaction." probably 1/10 times, can't reproduce reliably. maybe from here?

might be the case that the loader exists just isn't showing properly

@bdresser bdresser added the good first issue Good for newcomers label Jun 4, 2018
@danjm danjm added blocked and removed good first issue Good for newcomers labels Jun 25, 2018
@danjm danjm removed the blocked label Jul 12, 2018
@bdresser bdresser removed this from the Sprint 05 milestone Aug 7, 2018
@danfinlay
Copy link
Contributor Author

I just watched a hackathon video where metamask took like 20 seconds for the confirmation window to show anything. It's really painful. At least saying why they're waiting would be a big fix, I think it's often gas estimation.

@whymarrh
Copy link
Contributor

whymarrh commented Oct 2, 2018

As discussed a few days ago we'll close this for now an break out separate more specific issues

@whymarrh whymarrh closed this as completed Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UI Relating to the user interface. type-bug
Projects
None yet
Development

No branches or pull requests

4 participants