Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client side eth_estimateGas and eth_call #2991

Closed
wants to merge 2 commits into from
Closed

Client side eth_estimateGas and eth_call #2991

wants to merge 2 commits into from

Conversation

kumavis
Copy link
Member

@kumavis kumavis commented Jan 16, 2018

this adds the vm middleware to the provider stack

  • Need to add eth_estimateGas to vm-subprovider
  • Need to decide if we want to intercept eth_call client side

@kumavis kumavis added the DO-NOT-MERGE Pull requests that should not be merged label Jan 16, 2018
@kumavis
Copy link
Member Author

kumavis commented Jan 16, 2018

Also the package.json merge conflict was weird, i seemed to have added 2 deps somehow:

 "eth-hd-keyring": "^1.2.1",
"eth-simple-keyring": "^1.2.0",

@kumavis
Copy link
Member Author

kumavis commented Jan 18, 2018

they are actually included inside keyring controller

@danfinlay danfinlay mentioned this pull request May 5, 2018
Closed
@kumavis
Copy link
Member Author

kumavis commented Oct 10, 2018 •
edited
Loading

Can investigate later if we want

@kumavis kumavis closed this Oct 10, 2018
@whymarrh whymarrh deleted the clientSideEstimateGas branch November 19, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DO-NOT-MERGE Pull requests that should not be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kumavis