Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Custom RPC form #6209

Closed
bdresser opened this issue Feb 26, 2019 · 2 comments · Fixed by #6490
Closed

Improvements to Custom RPC form #6209

bdresser opened this issue Feb 26, 2019 · 2 comments · Fixed by #6490
Assignees
Labels
area-customNetworks area-settings area-UI Relating to the user interface.

Comments

@bdresser
Copy link
Contributor

bdresser commented Feb 26, 2019

Relates to general work to improve the Settings menu (#5790) but may be tackled separately / afterwards.

The custom RPC form is an important developer feature and we should give it its due!

Basic Functionality

We can add a top-level "Networks" category on the Settings designs outlined above. The category takes you to a page that lets you

  • see a list of all your networks
  • add a new custom network
  • tap in to an existing network to view and/or edit

for each network, users should be able to set

  • RPC URL (required)
  • nickname
  • chain ID
  • symbol (ETH, ETC, ...)
  • block explorer
  • color picker (nice-to-have)

Other in-scope updates

Block explorers

Updates to universal network dropdown

  • A fresh install of the extension should show Mainnet, Ropsten, Rinkeby, and "Manage Networks..." which will take the user to this page in settings
  • Network names in the top bar should end in ellipses so they don't clip the account image, as described in Custom RPC makes account switcher unavailable #6094
  • Behavior that persists saved networks and allows removing with the x should remain unchanged

Questions

  • We may allow the option to edit default networks (Mainnet, Ropsten, etc). If we do, probably wise to include aan additional warning / double confirmation and a "return to default settings" button for those networks.
  • Would be nice to include a "duplicate network" button somewhere on the index screen
  • Would be nice to allow removing custom networks from the index screen
  • Should we move the "show/hide fiat conversion on testnets" (Show/Hide Fiat on Testnets based on User Preference #6153) to a per-network setting? (i.e. "Show / hide fiat conversion on this network as a checkbox on each network form)

Addresses #5605, #5631, #5381, #6083, #6094

Working Mural is here

@bdresser bdresser added area-customNetworks area-UI Relating to the user interface. area-settings labels Feb 26, 2019
@bdresser
Copy link
Contributor Author

with these updates to block explorer, we should consider changing instances of "view on Etherscan" to
"view on block explorer"

@bdresser bdresser added this to the Sprint: 4.1 - 4.12 milestone Apr 1, 2019
@danjm danjm assigned danjm and unassigned chikeichan Apr 10, 2019
@danjm
Copy link
Contributor

danjm commented Apr 10, 2019

@bdresser Where are the finalized designs for this?

Never mind, found them :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-customNetworks area-settings area-UI Relating to the user interface.
Projects
None yet
3 participants