Show/Hide Fiat on Testnets based on User Preference #6153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chikeichan
commented
Feb 14, 2019
•
chikeichan
commented
- Show/Hide Fiat based on network type for sidebar, transaction-list, transaction-list-item balance display
- Show/Hide Fiat based on network type for account balance and currency-input on send screen
- Show/Hide Fiat based on network type for gas selectors on send screen
- Show/Hide Fiat based on network type for currency-input on send token screen
- Show/Hide Fiat based on network type for gas selectors on send token screen
- Show/Hide Fiat based on network type for all balances on confirm screen
- Show/Hide Fiat based on network type for all balances on confirm token screen
- Test Show/Hide in Contract Deploy
- Test Show/Hide in non-send actions (contract calls, sign message, etc)
- Add New Preference toggle
- Add Unit Tests
chikeichan
force-pushed
the
hide-fiat-testnets
branch
from
9bfdbd5 to
5ebc1a9
Compare
chikeichan
changed the title
chikeichan
force-pushed
the
hide-fiat-testnets
branch
from
817ca53 to
4d563df
Compare
|
danjm
previously approved these changes
Feb 25, 2019
… e2e test. Lint fix.
danjm
force-pushed
the
hide-fiat-testnets
branch
from
dcc61a0 to
2d732aa
Compare
danjm
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.