Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eth-ledger-bridge-keyring to v0.5.0 #11064

Merged
merged 1 commit into from
May 18, 2021

Conversation

darkwing
Copy link
Contributor

Fixes: #10240

Explanation: Updates our Ledger Bridge Keyring to 0.5.0, with support typed signing.

@darkwing darkwing requested a review from a team as a code owner May 12, 2021 14:47
@darkwing darkwing requested a review from adonesky1 May 12, 2021 14:47
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing requested a review from danjm May 14, 2021 15:22
@darkwing
Copy link
Contributor Author

Tagging @danjm for review as we worked on this at the beginning, I'd love for him to see it and approve.

@brad-decker
Copy link
Contributor

I used this to move LP from v2 to v3 on mainnet. Worked like a charm

Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darkwing darkwing merged commit da2e662 into MetaMask:develop May 18, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support EIP-712 signing for Ledger accounts
2 participants