Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add event property to event sent on tx:status-update in metamask-controller #11165

Merged
merged 1 commit into from
May 24, 2021
Merged

Add event property to event sent on tx:status-update in metamask-controller #11165

merged 1 commit into from
May 24, 2021

Conversation

danjm
Copy link
Contributor

@danjm danjm commented May 24, 2021

The metrics event sent when an onchain failure occurs, in the handler for the tx:status-update event in metamask-controller.js, was updated in 3d4dfc74a8. However, no event property was added

No event name was added. This causes a Must specify event and category. event to be registered in sentry.

This PR corrects that.

@danjm danjm requested a review from a team as a code owner May 24, 2021 09:50
@danjm danjm requested a review from darkwing May 24, 2021 09:50
dan437
dan437 approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@dan437 dan437 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@metamaskbot
Copy link
Collaborator

Builds ready [83fc2d0]
Page Load Metrics (588 ± 49 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44756094
domContentLoaded38475658610149
load38675758810249
domInteractive38475558510149

Gudahtt
Gudahtt approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danjm danjm merged commit 3cbef73 into develop May 24, 2021
@danjm danjm deleted the metrics-event-name-tx-status-update branch May 24, 2021 19:02
ryanml pushed a commit that referenced this pull request May 24, 2021
@danjm @ryanml
Add event property to event sent on tx:status-update in metamask-cont…
a137cd1 
…roller (#11165)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan437 dan437 dan437 approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

@darkwing darkwing Awaiting requested review from darkwing

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danjm @metamaskbot @Gudahtt @dan437