-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump controllers v30.0.2 #14906
Bump controllers v30.0.2 #14906
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
ed7a2fc
to
2d659e6
Compare
3b5e02a
to
e274d42
Compare
1679466
to
24336a7
Compare
a1c6c93
to
b8d4ca8
Compare
Builds ready [eb8f0bf]Page Load Metrics (1680 ± 36 ms)
highlights:storybook
|
a23c102
to
8f5914e
Compare
5483e03
to
b806bbc
Compare
app/scripts/metamask-controller.js
Outdated
onCollectibleAdded: ({ address, symbol, tokenId, standard, source }) => | ||
this.metaMetricsController.trackEvent({ | ||
token_contract_address: address, | ||
token_symbol: symbol, | ||
tokenId, | ||
asset_type: ASSET_TYPES.COLLECTIBLE, | ||
token_standard: standard, | ||
source, | ||
}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
listener method added to CollectiblesController
options object here
useStaticTokenList: !this.preferencesController.store.getState() | ||
.useTokenDetection, | ||
onNetworkStateChange: (cb) => | ||
this.networkController.store.subscribe((networkState) => { | ||
const modifiedNetworkState = { | ||
...networkState, | ||
provider: { | ||
...networkState.provider, | ||
chainId: hexToDecimal(networkState.provider.chainId), | ||
}, | ||
}; | ||
return cb(modifiedNetworkState); | ||
}), | ||
onPreferencesStateChange: (cb) => | ||
this.preferencesController.store.subscribe((preferencesState) => { | ||
const modifiedPreferencesState = { | ||
...preferencesState, | ||
useStaticTokenList: !this.preferencesController.store.getState() | ||
.useTokenDetection, | ||
}; | ||
return cb(modifiedPreferencesState); | ||
}), | ||
messenger: tokenListMessenger, | ||
state: initState.TokenListController, | ||
})); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useStaticTokenList
and onPreferencesStateChange
removed from TokenListController
options object here
@@ -1585,7 +1561,6 @@ export default class MetamaskController extends EventEmitter { | |||
tokensController, | |||
), | |||
updateTokenType: tokensController.updateTokenType.bind(tokensController), | |||
removeToken: tokensController.removeAndIgnoreToken.bind(tokensController), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removeAndIgnoreToken
method removed from TokensController
here
7a1a809
to
975d2d6
Compare
Builds ready [975d2d6]Page Load Metrics (1666 ± 34 ms)
highlights:storybook
|
* Pass phishfort specific new issue url to phishing-warning page. Co-authored-by: Alex Donesky <[email protected]> Co-authored-by: Ariella Vu <[email protected]> Co-authored-by: PeterYinusa <[email protected]>
975d2d6
to
1d4dffa
Compare
Builds ready [1d4dffa]Page Load Metrics (1800 ± 101 ms)
highlights:storybook
|
Fixes: #14891
Updates
@metamask/controllers
to v30.0.2 and adapts to all of the breaking changes introduced in the latest major version bump (v30.0.0)Most changes that this new controllers version introduces are related to Token Detection V2 & NFT support.
I left comments within the changes to explain most non-obvious changes, but there may still be some unexplained (and non-obvious) changes, so please don't hesitate to ask.
Key flows to test:
COLLECTIBLES_V1=1
in.metamaskrc
a. Adding manually
b. Adding via auto-detection
c. Transferring
d. Approving (
approve()
andsetApprovalForAll()
)Let me know if you have any questions about how to test any of the flows described above!