upgrade jest #15642
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| diff --git a/node_modules/@types/jsdom/node_modules/parse5/dist/index.d.ts b/node_modules/@types/jsdom/node_modules/parse5/dist/index.d.ts | ||
| index 81253d3..d2333bf 100644 | ||
| --- a/node_modules/@types/jsdom/node_modules/parse5/dist/index.d.ts | ||
| +++ b/node_modules/@types/jsdom/node_modules/parse5/dist/index.d.ts | ||
| @@ -1,10 +1,10 @@ | ||
| -import { type ParserOptions } from './parser/index.js'; | ||
| +import { ParserOptions } from './parser/index.js'; | ||
|
There was a problem hiding this comment. Sorry why do we have to remove There was a problem hiding this comment. running tsc throws errors for using type keyword inside the brackets. You can import types and non types without specifying a keyword There was a problem hiding this comment. Ohh... wow. That's subtle. How do other people even use this package then 🤔 There was a problem hiding this comment. no idea. unless it has something to do with our setup. |
||
| import type { DefaultTreeAdapterMap } from './tree-adapters/default.js'; | ||
| import type { TreeAdapterTypeMap } from './tree-adapters/interface.js'; | ||
| -export { type DefaultTreeAdapterMap, defaultTreeAdapter } from './tree-adapters/default.js'; | ||
| +export { DefaultTreeAdapterMap, defaultTreeAdapter } from './tree-adapters/default.js'; | ||
| export type { TreeAdapter, TreeAdapterTypeMap } from './tree-adapters/interface.js'; | ||
| -export { type ParserOptions, /** @internal */ Parser } from './parser/index.js'; | ||
| -export { serialize, serializeOuter, type SerializerOptions } from './serializer/index.js'; | ||
| +export { ParserOptions, /** @internal */ Parser } from './parser/index.js'; | ||
| +export { serialize, serializeOuter, SerializerOptions } from './serializer/index.js'; | ||
| export type { ParserError } from './common/error-codes.js'; | ||
| /** @internal */ | ||
| export * as foreignContent from './common/foreign-content.js'; | ||
| @@ -13,7 +13,7 @@ export * as html from './common/html.js'; | ||
| /** @internal */ | ||
| export * as Token from './common/token.js'; | ||
| /** @internal */ | ||
| -export { Tokenizer, type TokenizerOptions, TokenizerMode, type TokenHandler } from './tokenizer/index.js'; | ||
| +export { Tokenizer, TokenizerOptions, TokenizerMode, TokenHandler } from './tokenizer/index.js'; | ||
| /** | ||
| * Parses an HTML string. | ||
| * | ||
| diff --git a/node_modules/@types/jsdom/node_modules/parse5/dist/parser/index.d.ts b/node_modules/@types/jsdom/node_modules/parse5/dist/parser/index.d.ts | ||
| index 50a9bd0..df1863e 100644 | ||
| --- a/node_modules/@types/jsdom/node_modules/parse5/dist/parser/index.d.ts | ||
| +++ b/node_modules/@types/jsdom/node_modules/parse5/dist/parser/index.d.ts | ||
| @@ -1,10 +1,10 @@ | ||
| -import { Tokenizer, TokenizerMode, type TokenHandler } from '../tokenizer/index.js'; | ||
| -import { OpenElementStack, type StackHandler } from './open-element-stack.js'; | ||
| +import { Tokenizer, TokenizerMode, TokenHandler } from '../tokenizer/index.js'; | ||
| +import { OpenElementStack, StackHandler } from './open-element-stack.js'; | ||
| import { FormattingElementList } from './formatting-element-list.js'; | ||
| -import { ERR, type ParserErrorHandler } from '../common/error-codes.js'; | ||
| +import { ERR, ParserErrorHandler } from '../common/error-codes.js'; | ||
| import { TAG_ID as $, NS } from '../common/html.js'; | ||
| import type { TreeAdapter, TreeAdapterTypeMap } from '../tree-adapters/interface.js'; | ||
| -import { type Token, type CommentToken, type CharacterToken, type TagToken, type DoctypeToken, type EOFToken, type LocationWithAttributes } from '../common/token.js'; | ||
| +import { Token, CommentToken, CharacterToken, TagToken, DoctypeToken, EOFToken, LocationWithAttributes } from '../common/token.js'; | ||
| declare enum InsertionMode { | ||
| INITIAL = 0, | ||
| BEFORE_HTML = 1, | ||
| diff --git a/node_modules/@types/jsdom/node_modules/parse5/dist/serializer/index.d.ts b/node_modules/@types/jsdom/node_modules/parse5/dist/serializer/index.d.ts | ||
| index d944fae..432464c 100644 | ||
| --- a/node_modules/@types/jsdom/node_modules/parse5/dist/serializer/index.d.ts | ||
| +++ b/node_modules/@types/jsdom/node_modules/parse5/dist/serializer/index.d.ts | ||
| @@ -1,5 +1,5 @@ | ||
| import type { TreeAdapter, TreeAdapterTypeMap } from '../tree-adapters/interface'; | ||
| -import { type DefaultTreeAdapterMap } from '../tree-adapters/default.js'; | ||
| +import { DefaultTreeAdapterMap } from '../tree-adapters/default.js'; | ||
| export interface SerializerOptions<T extends TreeAdapterTypeMap> { | ||
| /** | ||
| * Specifies input tree format. | ||
| diff --git a/node_modules/@types/jsdom/node_modules/parse5/dist/tokenizer/index.d.ts b/node_modules/@types/jsdom/node_modules/parse5/dist/tokenizer/index.d.ts | ||
| index de6e234..89e2484 100644 | ||
| --- a/node_modules/@types/jsdom/node_modules/parse5/dist/tokenizer/index.d.ts | ||
| +++ b/node_modules/@types/jsdom/node_modules/parse5/dist/tokenizer/index.d.ts | ||
| @@ -1,6 +1,6 @@ | ||
| import { Preprocessor } from './preprocessor.js'; | ||
| -import { type CharacterToken, type DoctypeToken, type TagToken, type EOFToken, type CommentToken } from '../common/token.js'; | ||
| -import { type ParserErrorHandler } from '../common/error-codes.js'; | ||
| +import { CharacterToken, DoctypeToken, TagToken, EOFToken, CommentToken } from '../common/token.js'; | ||
| +import { ParserErrorHandler } from '../common/error-codes.js'; | ||
| declare const enum State { | ||
| DATA = 0, | ||
| RCDATA = 1, | ||
| diff --git a/node_modules/@types/jsdom/node_modules/parse5/dist/tokenizer/preprocessor.d.ts b/node_modules/@types/jsdom/node_modules/parse5/dist/tokenizer/preprocessor.d.ts | ||
| index e74a590..d145dcc 100644 | ||
| --- a/node_modules/@types/jsdom/node_modules/parse5/dist/tokenizer/preprocessor.d.ts | ||
| +++ b/node_modules/@types/jsdom/node_modules/parse5/dist/tokenizer/preprocessor.d.ts | ||
| @@ -1,4 +1,4 @@ | ||
| -import { ERR, type ParserError, type ParserErrorHandler } from '../common/error-codes.js'; | ||
| +import { ERR, ParserError, ParserErrorHandler } from '../common/error-codes.js'; | ||
| export declare class Preprocessor { | ||
| private handler; | ||
| html: string; | ||
| diff --git a/node_modules/@types/jsdom/node_modules/parse5/dist/tree-adapters/default.d.ts b/node_modules/@types/jsdom/node_modules/parse5/dist/tree-adapters/default.d.ts | ||
| index cccdf8f..d70b8fa 100644 | ||
| --- a/node_modules/@types/jsdom/node_modules/parse5/dist/tree-adapters/default.d.ts | ||
| +++ b/node_modules/@types/jsdom/node_modules/parse5/dist/tree-adapters/default.d.ts | ||
| @@ -1,4 +1,4 @@ | ||
| -import { DOCUMENT_MODE, type NS } from '../common/html.js'; | ||
| +import { DOCUMENT_MODE, NS } from '../common/html.js'; | ||
| import type { Attribute, Location, ElementLocation } from '../common/token.js'; | ||
| import type { TreeAdapter, TreeAdapterTypeMap } from './interface.js'; | ||
| export declare enum NodeType { | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
multiformats,uuid, andnanoidmakes sense, because they have recently(ish) converted to ESM, and I've seen Jest choke on these packages in other projects.We don't ship ESM code in
@metamask/controllersor@metamask/snap-controllers, however, so why did we have to list these here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some of the dependencies nested inside the metamask/controllers repo are ESM and i could not figure out how to specify that recursion in this ignore pattern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see. Interesting...