Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(21438): remove action queue related config #21460

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

DDDDDanica
Copy link
Contributor

Description

Given recent updates from the chrome team detailed on 21067, we don't expect service workers to restart anymore. As such, it makes no sense to have action queue included in any config. Hence we delete the introduced action queue configuration for e2e from #18346/

Manual testing steps

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change.

Before

[screenshot]

After

[screenshot]

Related issues

Fix: https://app.zenhub.com/workspaces/metamask-extension-63529dce65cbb100265a3842/issues/gh/metamask/metamask-extension/21438

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@DDDDDanica DDDDDanica added the team-extension-platform Extension Platform team label Oct 19, 2023
@DDDDDanica DDDDDanica self-assigned this Oct 19, 2023
@DDDDDanica DDDDDanica requested a review from a team as a code owner October 19, 2023 13:25
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@DDDDDanica DDDDDanica force-pushed the feature/21438-action-queue-config branch 9 times, most recently from a116f18 to ae0b528 Compare October 23, 2023 16:21
@DDDDDanica DDDDDanica force-pushed the feature/21438-action-queue-config branch from ae0b528 to f2c3803 Compare October 23, 2023 16:34
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3143e8a) 68.63% compared to head (f2c3803) 68.64%.
Report is 15 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #21460      +/-   ##
===========================================
+ Coverage    68.63%   68.64%   +0.02%     
===========================================
  Files         1030     1029       -1     
  Lines        41050    41033      -17     
  Branches     10961    10963       +2     
===========================================
- Hits         28171    28166       -5     
+ Misses       12879    12867      -12     
Files Coverage Δ
app/scripts/controllers/app-state.js 39.69% <ø> (+0.60%) ⬆️
app/scripts/lib/setupSentry.js 41.07% <ø> (ø)
app/scripts/metamask-controller.js 55.72% <ø> (+0.29%) ⬆️
shared/constants/metametrics.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [f2c3803]
Page Load Metrics (1338 ± 352 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8212498126
domContentLoaded6812294136
load8021471338733352
domInteractive6812294136
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -1.19 KiB (-0.03%)
  • ui: 0 Bytes (0.00%)
  • common: -118 Bytes (-0.00%)

@DDDDDanica DDDDDanica merged commit 4ea5251 into develop Oct 25, 2023
@DDDDDanica DDDDDanica deleted the feature/21438-action-queue-config branch October 25, 2023 15:03
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2023
@metamaskbot metamaskbot added the release-11.5.0 Issue or pull request that will be included in release 11.5.0 label Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.5.0 Issue or pull request that will be included in release 11.5.0 team-extension-platform Extension Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants