feat: replace EnsController with core implementation #23224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
cryptodev-2s
changed the title
|
@metamaskbot update-policies |
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
Policies updated |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23224 +/- ##
===========================================
- Coverage 68.65% 68.61% -0.05%
===========================================
Files 1098 1096 -2
Lines 43185 43091 -94
Branches 11532 11513 -19
===========================================
- Hits 29647 29563 -84
+ Misses 13538 13528 -10 ☔ View full report in Codecov by Sentry. |
Builds ready [28d5e6d]
Page Load Metrics (1149 ± 469 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [f068975]
Page Load Metrics (1327 ± 397 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
legobeat
reviewed
Feb 29, 2024
| @@ -1,29 +0,0 @@ | |||
| import { Web3Provider } from '@ethersproject/providers'; | |||
| import ensNetworkMap from 'ethereum-ens-network-map'; | |||
There was a problem hiding this comment.
Since this package is now no longer imported directly, it can now be removed from dependencies in package.json.
There was a problem hiding this comment.
@legobeat I see that it's still being used here https://github.com/MetaMask/metamask-extension/blob/develop/ui/ducks/domains.js#L3
There was a problem hiding this comment.
Hmm, interesting. I wonder if there's some duplicate code that we need to get rid or move into EnsController. We can revisit this in a future PR.
There was a problem hiding this comment.
Right. I'm thinking it could be inlined at this point, making it more obvious what's going on?
- Less duplicate code and more out-of-date configuration by the looks of it: feat(ens-controller): Allow supplying ENS network map in constructor core#4006
There was a problem hiding this comment.
Oh I see, yes, if we inline the ENS registry map then we can bring it in from ens-controller for that particular use case. That makes sense.
Builds ready [61c5c74]
Page Load Metrics (1053 ± 302 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
legobeat
approved these changes
Mar 1, 2024
Builds ready [9a4a742]
Page Load Metrics (1428 ± 333 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
metamaskbot
added
the
release-11.13.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the successful merge of EnsController from the extension to the core Existing EnsController as detailed in MetaMask/core#1129, we should now fully remove the EnsController logic from the extension and instead rely entirely on the core monorepo implementation.
Related issues
Fixes: 23223
Changelog
Pre-merge reviewer checklist