Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

info.js Remove width element to fix email layout #2855

Merged
merged 1 commit into from
Jan 9, 2018

Conversation

abitrolly
Copy link
Contributor

This should fix the bug with email layout:

screenshot from 2018-01-04 17-07-35

But I haven't tested it, because I couldn't find a way to edit extension HTML from FF.

@kumavis
Copy link
Member

kumavis commented Jan 9, 2018

Verified this fixes the positioning on Firefox
Does affect section header / back arrow positioning, but its subtle and possibly looks more centered

thanks @abitrolly !

@kumavis kumavis merged commit 096fb22 into MetaMask:master Jan 9, 2018
@abitrolly
Copy link
Contributor Author

image

Looks better now. )

@abitrolly abitrolly deleted the patch-2 branch January 10, 2018 01:03
@abitrolly
Copy link
Contributor Author

Broken again in 4.7.4

image

abitrolly added a commit to abitrolly/metamask-extension that referenced this pull request Jul 19, 2018
Fix for MetaMask#2855 which is gone from master for some reason
whymarrh pushed a commit that referenced this pull request Aug 16, 2018
Fix for #2855 which is gone from master for some reason
danjm pushed a commit that referenced this pull request Aug 17, 2018
Fix for #2855 which is gone from master for some reason
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants