Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e beta test upgrades for confirm refactor #4764

Merged

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Jul 10, 2018

This PR makes a number of improvements to the e2e tests, while also making specific changes needed for the confirm refactor.

The general improvements include:

  • replacing reliance on external urls for tests of external dapp behaviour with a locally served dapp
  • replacing the assumption that webdriver's getAllWindowHandles method returns window handles in the order that they are opened. Instead, windows are selected by conditions that specifically identify the window we are looking for
  • adds a helper method for asserting that elements are not found in the dom
  • adds helper methods for selecting windows by document title and closing windows other than those specified

Confirm refactor specific updates include:

  • testing of erc20 "Approve" confirmations
  • testing the new data tab on the confirm screen
  • testing that contract creation data is as expected
  • updates to meeting the new confirm ui

This PR also includes updates to the integration tests to ensure they pass given updates to confirm screen html/css and updates to how the routing system handles unapproved transactions

@danjm danjm force-pushed the i4404-confirm-refactor-with-e2e-upgrades branch from 4ae18d6 to a86dd83 Compare July 10, 2018 19:30
@danjm danjm force-pushed the i4404-confirm-refactor-with-e2e-upgrades branch from a86dd83 to 409bffe Compare July 10, 2018 19:52
@danjm danjm force-pushed the i4404-confirm-refactor-with-e2e-upgrades branch from 409bffe to 91eca55 Compare July 11, 2018 11:05
danjm added 4 commits July 11, 2018 13:37
…n to contain localhost before attempting to click. (e2e beta tests)
…ered before attempting to select the tx-list-item. (e2e beta tests)
@metamaskbot
Copy link
Collaborator

Builds ready [07322bc]: mascara, chrome, firefox, edge, opera

@danjm danjm merged commit 92fc87a into i4404-confirm-refactor Jul 11, 2018
@danjm danjm deleted the i4404-confirm-refactor-with-e2e-upgrades branch July 12, 2018 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants