e2e beta test upgrades for confirm refactor #4764
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a number of improvements to the e2e tests, while also making specific changes needed for the confirm refactor.
The general improvements include:
getAllWindowHandles
method returns window handles in the order that they are opened. Instead, windows are selected by conditions that specifically identify the window we are looking forConfirm refactor specific updates include:
This PR also includes updates to the integration tests to ensure they pass given updates to confirm screen html/css and updates to how the routing system handles unapproved transactions