Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sesify-viz - bump dep for visualization enhancement #7175

Merged
merged 5 commits into from
Sep 23, 2019
Merged

Conversation

kumavis
Copy link
Member

@kumavis kumavis commented Sep 17, 2019

No description provided.

@metamaskbot
Copy link
Collaborator

Builds ready [af0e879]

@kumavis
Copy link
Member Author

kumavis commented Sep 17, 2019

repo now includes the react app https://github.com/kumavis/sesify-viz

@metamaskbot
Copy link
Collaborator

Builds ready [2839bcb]

@kumavis
Copy link
Member Author

kumavis commented Sep 17, 2019

hmm not ready yet

@kumavis
Copy link
Member Author

kumavis commented Sep 17, 2019

fyi got a random failure in test-e2e-firefox

@metamaskbot
Copy link
Collaborator

Builds ready [0f888eb]

package.json Outdated Show resolved Hide resolved
@Gudahtt
Copy link
Member

Gudahtt commented Sep 17, 2019

fyi got a random failure in test-e2e-firefox

Both of the e2e tests suffer from ~3 different intermittent failures, sadly. We haven't found the cause yet.

Gudahtt
Gudahtt previously approved these changes Sep 17, 2019
@Gudahtt
Copy link
Member

Gudahtt commented Sep 17, 2019

Nice! I appreciate the package metadata being in the top-left now. It also seems to persist if you mouse away quickly, which is useful.

I did get an error when clicking on one of the other tabs though:

ReferenceError: triggerGraphUpdate is not defined

@Gudahtt Gudahtt dismissed their stale review September 17, 2019 17:32

Error found

@kumavis
Copy link
Member Author

kumavis commented Sep 17, 2019

fixed the bug in the viz app
yeah its still not very good, but just beginning
give me feature requests

@metamaskbot
Copy link
Collaborator

Builds ready [2626a2f]

Gudahtt
Gudahtt previously approved these changes Sep 18, 2019
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! No more error.

@kumavis
Copy link
Member Author

kumavis commented Sep 23, 2019

fixed a yarn.lock conflict

@metamaskbot
Copy link
Collaborator

Builds ready [1207926]

@kumavis kumavis merged commit 8a1ddbb into develop Sep 23, 2019
@kumavis kumavis deleted the sesify-viz-update branch September 23, 2019 03:14
Gudahtt added a commit to Gudahtt/metamask-extension that referenced this pull request Sep 27, 2019
* origin/develop: (56 commits)
  Add advanced setting to enable editing nonce on confirmation screens (MetaMask#7089)
  Add migration on 3box imports and remove feature flag (MetaMask#7209)
  ci - install deps - limit install scripts to whitelist (MetaMask#7208)
  Add a/b test for full screen transaction confirmations (MetaMask#7162)
  Update minimum Firefox verison to 56.0 (MetaMask#7213)
  mesh-testing - submit infura rpc requests to mesh-testing container (MetaMask#7031)
  obs-store/local-store should upgrade webextension error to real error (MetaMask#7207)
  sesify-viz - bump dep for visualization enhancement (MetaMask#7175)
  address book entries by chainId (MetaMask#7205)
  Optimize images only during production build (MetaMask#7194)
  Use common test build during CI (MetaMask#7196)
  Report missing `en` locale messages to Sentry (MetaMask#7197)
  Verify locales on CI (MetaMask#7199)
  updated ganache and addons-linter (MetaMask#7204)
  fixup! add user rejected errors
  add user rejected errors
  update json-rpc-engine
  use eth-json-rpc-errors
  Remove unused locale messages (MetaMask#7190)
  Remove unused components (MetaMask#7191)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants