Update tokens dependency for effect

MetaMask · Nov 17, 2020 · 24b5456 · 24b5456
1 parent 1662700
commit 24b5456
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/app/components/UI/Swaps/index.js b/app/components/UI/Swaps/index.js
@@ -130,13 +130,11 @@ function SwapsAmountView({ tokens, accounts, selectedAddress, balances }) {
 			} catch (err) {
 				console.error(err);
 			} finally {
-				setLoadingTokens(() => false);
-				setInitialLoadingTokens(() => false);
+				setLoadingTokens(false);
+				setInitialLoadingTokens(false);
 			}
 		})();
-		// TODO(wachunei) include tokens in deps once controller is updated with cache timestamp
-		// eslint-disable-next-line react-hooks/exhaustive-deps
-	}, []);
+	}, [tokens]);
 
 	useEffect(() => {
 		if (initialSource && tokens && !sourceToken) {