Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for eth_sign #1109

Closed
danfinlay opened this issue Sep 25, 2019 · 0 comments · Fixed by #1151
Closed

Add support for eth_sign #1109

danfinlay opened this issue Sep 25, 2019 · 0 comments · Fixed by #1151
Assignees
@estebanmino

Comments

@danfinlay
Copy link
Contributor

Previously reported in #169, but it seems like only personal_sign was implemented.

Should be coupled with the big scary warning like we use in desktop:
https://github.com/MetaMask/metamask-extension/blob/e0e06709d3ea79db3830bf1e68667bc41b1fa732/app/_locales/en/messages.json#L1559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@estebanmino estebanmino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature: message eth sign + Address Book Migration MetaMask/metamask-mobile
2 participants
@danfinlay @estebanmino