Feature: message eth sign + Address Book Migration #1151
Conversation
estebanmino
changed the title
|
Issue 1: on Android device, tapping on learn more next to the security message, nothing happens, seen here = seen here = http://recordit.co/LtyaVQUfsT it doesn’t open the zendesk article like in iOS Issue 2: I wanted to test wallet connect signing, but when I'm on Android, on the wallet view and tap on the scanner icon at top right, app crashes seen here = http://recordit.co/bwX2XQuf9B Issue 3: On iOS, I just sent eth from this account to ibrahimtester.eth and when I tap the drop down I don't see it appear in the list
On Android, app crashes immediately when attempting to send Seen here = https://recordit.co/Thz9Iixz0R |
estebanmino
force-pushed
the
feature/message-eth-sign
branch
from
01cfb0b to
1a08df0
Compare
ibrahimtaveras00
added
the
needs-qa
|
Fixes look good on both OS's, QA passed 👍 |
There was a problem hiding this comment.
This looks good. One minor comment, and @ibrahimtaveras00 make sure you run the app on develop first, then rebuild (without reinstalling) to test the address book. Previous contacts should still be available.
app/store/index.js
Outdated
| storage: AsyncStorage, | ||
| stateReconciler: autoMergeLevel2 // see "Merge Process" section for details. | ||
| stateReconciler: autoMergeLevel2, // see "Merge Process" section for details. | ||
| migrate: createMigrate(migrations, { debug: true }) |
There was a problem hiding this comment.
@estebanmino Should this debug:true flag still be here?
brunobar79
changed the title
|
Last test case looks good 👍 Sent some tokens to address ending in E69a and ibrahimtester.eth on develop, then after building this branch, double checked and addresses were still displayed in the dropdown, = http://recordit.co/28rnZffWSC |
* wip number methods * snaps * sign messasge * 13.1 * bump gaba * snaps * to string * fix android issue * fix address book * add gaba again * add gaba again * fix network * add eth_sign to wallet connect * lock * debig false
Description
Add support for eth_sign.
BLOCKED BY GABA
Checklist
Issue
Resolves #961
Resolves #1109