Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create transaction data modal #1499

Closed
danjm opened this issue Apr 20, 2020 · 0 comments · Fixed by #1559 or #9042
Closed

Create transaction data modal #1499

danjm opened this issue Apr 20, 2020 · 0 comments · Fixed by #1559 or #9042
Assignees
@EtDu
Labels
release-7.20.0 Issue or pull request that will be included in release 7.20.0

Comments

@danjm
Copy link
Contributor

danjm commented Apr 20, 2020

The task is to create the new data modal being used across the latest confirmation designs:

Screenshot from 2020-04-20 15-24-49

For now, this can be implemented to replace the data section of the Approve screens:

Screenshot from 2020-04-20 15-32-29

(Code for that screen: metamask-mobile/app/components/Views/ApproveView/Approve/index.js)

Designs: https://www.figma.com/file/dzapXt5s0pKBxb9lZkIoDM/%231352---Confirm-transactions?node-id=916%3A101
This was referenced Apr 20, 2020
Closed
Closed
@EtDu EtDu mentioned this issue Apr 27, 2020
Merged
7 tasks
@EtDu EtDu mentioned this issue May 12, 2020
Merged
4 tasks
@EtDu EtDu closed this as completed in #1559 Jul 7, 2020
@Cal-L Cal-L mentioned this issue Mar 22, 2024
Merged
7 tasks
Cal-L added a commit that referenced this issue Mar 23, 2024
@Cal-L
fix: Refactor SDK initialization (#9042)
4bbbbac 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR simplifies SDK initialization logic, which was causing the
security modal to re-render, which was breaking both performance and E2E
tests

Fixes #1499 

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

https://recordit.co/NcG1KbKuxH

### **After**

<!-- [screenshots/recordings] -->



https://github.com/MetaMask/metamask-mobile/assets/10508597/c50bd819-71e5-42b1-8236-4fe0acb41547



## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-7.20.0 Issue or pull request that will be included in release 7.20.0 label Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EtDu EtDu

Labels
release-7.20.0 Issue or pull request that will be included in release 7.20.0
Projects
None yet
Milestone
No milestone
3 participants
@danjm @EtDu @metamaskbot