Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect values on txn details and payment request deeplink #1914

Closed
ibrahimtaveras00 opened this issue Oct 26, 2020 · 4 comments · Fixed by #2104
Closed

Incorrect values on txn details and payment request deeplink #1914

ibrahimtaveras00 opened this issue Oct 26, 2020 · 4 comments · Fixed by #2104
Assignees
Labels
Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking support type-bug Something isn't working

Comments

@ibrahimtaveras00
Copy link
Contributor

Describe the bug
When sending more than 999 tokens, there are 2 noticeable issues

  • Issue 1:
    txn details show incorrect value

image

  • Issue 2:
    When attempting to send more than 999 tokens in a payment request, the value is incorrect when the confirm view loads

image

Issue 2 currently is broken on playstore, once #1877 is merged into develop, you should be able to at least load the deeplink to get to the confirm view

To Reproduce
Steps to reproduce the behavior
to reproduce Issue 2, create a request for more than 999 of any ERC20 token that you want
or use my example by scanning the QR code in the above screen shot

for issue 1, once you actually send the tokens, look at the txn details total amount value

Expected behavior
For issue 1= the txn details should display the correct value

For issue 2 = the deeplink should have the correct requested value amount


to be added after bug submission by internal support / PM
Severity

  • How critical is the impact of this bug on a user?
  • Add stats if available on % of customers impacted
  • Is this visible to all users?
  • Is this tech debt?
@ibrahimtaveras00 ibrahimtaveras00 added the type-bug Something isn't working label Oct 26, 2020
@ibrahimtaveras00
Copy link
Contributor Author

@omnat I already added this one to the backlog

@omnat omnat added Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking support labels Nov 19, 2020
@roo-shy
Copy link

roo-shy commented Nov 19, 2020

#65204 might help with the investigation ^^

@omnat
Copy link
Contributor

omnat commented Dec 10, 2020

Possibly related #2017

@ahsimon2
Copy link

ahsimon2 commented Dec 10, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking support type-bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants