Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-detection of collectibles is inconsistent #2740

Closed
mobularay opened this issue Jun 2, 2021 · 2 comments · Fixed by #2749
Closed

Auto-detection of collectibles is inconsistent #2740

mobularay opened this issue Jun 2, 2021 · 2 comments · Fixed by #2749
Assignees
@estebanmino
Labels
NFTs issues related to collectibles - ERC721, ERC1155 type-bug Something isn't working

Comments

@mobularay
Copy link
Contributor

mobularay commented Jun 2, 2021 •
edited
Loading

When auto detecting collectibles, there are some cases where some collectibles were detected in the wrong account.

Represents this shared controller work on the Mobile board: MetaMask/core#487
@mobularay mobularay added type-bug Something isn't working NFTs issues related to collectibles - ERC721, ERC1155 labels Jun 2, 2021
@mobularay
Copy link
Contributor Author

Currently waiting for Dev Review

@mobularay mobularay added the No QA Needed Apply this label when your PR does not need any QA effort. label Jun 3, 2021
@mobularay
Copy link
Contributor Author

Dev reviewed already
Need to merge first, then can close

@estebanmino estebanmino mentioned this issue Jun 4, 2021
Merged
3 tasks
@mobularay mobularay removed the No QA Needed Apply this label when your PR does not need any QA effort. label Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@estebanmino estebanmino

Labels
NFTs issues related to collectibles - ERC721, ERC1155 type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

@metamask/[email protected] MetaMask/metamask-mobile
2 participants
@estebanmino @mobularay