bugfix/collectible detection by acccount #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
approved these changes
Jun 3, 2021
| @@ -355,9 +355,10 @@ export class AssetsDetectionController extends BaseController< | |||
| if (!this.isMainnet()) { | |||
| return; | |||
| } | |||
| const { selectedAddress } = this.config; | |||
| const requestedSelectedAddress = this.config.selectedAddress; | |||
There was a problem hiding this comment.
any particular reason for the rename? seems selectedAddress would still be fine no?
There was a problem hiding this comment.
hm not really, just to be clear that it was the address from where it was being called
There was a problem hiding this comment.
I can go back to selectedAddress if you want 👌
There was a problem hiding this comment.
nah it's fine.
just to be clear that it was the address from where it was being called
I think that's plenty reason enough to rename. feel free to merge.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When auto detecting collectibles there are some cases where some collectibles were detected in the wrong account. One way I could reproduce that was in the following case
0x9and we're waiting for the response from API https://github.com/MetaMask/controllers/compare/bugfix/assets-detection-by-acccount?expand=1#diff-3202c2273084eb58dae3e0d4e23765dce262bb24c93eb3bf166c56d2d7bf02c8R3650x120x9but they are added to0x12, so we have the wrong assets into the account.I could repro that with tests, removing this check https://github.com/MetaMask/controllers/compare/bugfix/assets-detection-by-acccount?expand=1#diff-3202c2273084eb58dae3e0d4e23765dce262bb24c93eb3bf166c56d2d7bf02c8R401