Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectively persist controller states #3308

Closed
Cal-L opened this issue Oct 19, 2021 · 0 comments
Closed

Selectively persist controller states #3308

Cal-L opened this issue Oct 19, 2021 · 0 comments
Assignees

Comments

@Cal-L
Copy link
Contributor

Cal-L commented Oct 19, 2021

Description

This ticket will aim to reduce the amount of data that gets persisted. However, for the UI to register controller changes, we'll still need to store necessary data in Redux. Data that is omitted from persist should be stored under some key in Redux.

Technical Details

  • Idea: We could store omitted data using the same controller structure so that UI changes will be minimal when referencing this data. For example: we could store the omitted data under a key called tempBackgroundState so we'd just have to replace backgroundState in redux selectors with tempBackgroundState.
  • Pull out phishing list from PhishingController
  • Pull out token list from TokenListController
  • TBD: Pull out data from SwapsController, will need to consult @wachunei

Acceptance Criteria

  • Phishing list is still respected when accessing the browser
  • Token detection should function the same as before
  • Swaps should function the same as before
  • TBD: Double check dependencies between persisted + non-persisted data to ensure that this selective persisting method makes sense
@Cal-L Cal-L changed the title Store large data sets under non-persisted keys Selectively persist controller states Oct 19, 2021
@sethkfman sethkfman linked a pull request Oct 19, 2021 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants