Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/3308 isolate persisted data #3325

Merged
merged 6 commits into from
Oct 22, 2021
Merged

Improvement/3308 isolate persisted data #3325

merged 6 commits into from
Oct 22, 2021

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Oct 22, 2021

Description

#3308

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@Cal-L Cal-L requested a review from a team as a code owner October 22, 2021 09:23
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Oct 22, 2021
sethkfman
sethkfman reviewed Oct 22, 2021
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question & comment

app/reducers/user/index.js Show resolved Hide resolved
app/store/index.js Show resolved Hide resolved
rickycodes
rickycodes reviewed Oct 22, 2021
View reviewed changes
package.json Outdated
@@ -144,6 +144,7 @@
"is-url": "^1.2.4",
"json-rpc-engine": "^6.1.0",
"json-rpc-middleware-stream": "3.0.0",
"lodash": "^4.17.21",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're only using omit, so i am wondering if we can use just that eg: "lodash.omit": "^4.5.0",

you'll also need to update your import to: import omit from 'lodash.omit';

@Cal-L Cal-L force-pushed the improvement/3308-isolate-persisted-data branch from c35645f to 2ebf09f Compare October 22, 2021 18:10
@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Oct 22, 2021
cortisiko
cortisiko approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA PASS! 🦖

@Cal-L Cal-L merged commit 2300d2b into develop Oct 22, 2021
@Cal-L Cal-L deleted the improvement/3308-isolate-persisted-data branch October 22, 2021 18:53
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2021
@Cal-L Cal-L removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rickycodes rickycodes rickycodes left review comments

@sethkfman sethkfman sethkfman left review comments

@cortisiko cortisiko cortisiko approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Cal-L @rickycodes @sethkfman @cortisiko