fix(deps): unpin [email protected],x [email protected] #11972

legobeat · 2024-10-23T10:10:29Z

Description

Unpin and dedupe ethereumjs-util and ethereumjs-abi while staying on legacy v6
Replace import { BN } from 'ethereumjs-util' with importing BN explicitly from either bn.js@4 or bn.js@5
- Mixing the two is not safe and can cause breakage.
  - Some on why this is A Bad Thing
- We don't get complete and correct typings with importing the old re-export
- This adds both v4 and v5 as explicit dependencies - ideally v4 will be removed as transition to v5 concludes
- Add EIP-1191 address checksum algorithm support for toChecksumAddress()
- Unblock relying on the ancient and deprecated [email protected]
ethereumjs-util changelog
[email protected]

Related issues

Blocking

fix(deps): ethereumjs-util@6->^7.1.5 #11932
- fix: remove usage of bn.js v4 #12043
- fix: migrate from deprecated legacy packages #11968

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-10-23T10:10:45Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-10-23T10:11:50Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@types/[email protected]	None	`0`	13.9 kB	types
npm/@types/[email protected]	None	`0`	13.9 kB	types
npm/[email protected]	None	`+2`	1.05 MB	holgerd77

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

yarn.lock

github-actions · 2024-10-23T10:47:10Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b708bac
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/619aa4be-9711-4726-9e62-08968d39e035

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-10-29T20:43:39Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1500bff
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2df7ff86-fe10-499c-8e6a-97b5c0e16917

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

- to get correct types - to prepare upgrading to versions which don't provide the re-export - fix: vendor BNToHex and hexToBN in order to use bn.js v4 - fix: explicitly use either bn.js@4 and bn.js@5 - Why mixing v4 and v5 is A Bad Thing: ethereumjs/ethereumjs-util#250

sonarqubecloud · 2024-10-30T00:44:34Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
78.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-10-30T04:02:41Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d2f0719
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5886ed6b-187f-495c-b3d9-d4050a36114e

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions bot added the team-lavamoat label Oct 23, 2024

legobeat added dependencies Pull requests that update a dependency file team-security Run Smoke E2E Triggers smoke e2e on Bitrise and removed team-lavamoat labels Oct 23, 2024

This comment was marked as outdated.

Sign in to view

legobeat force-pushed the deps-ethereumjs-6 branch from 48fbf0b to ff87271 Compare October 23, 2024 10:18

legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 23, 2024

This comment was marked as outdated.

Sign in to view

legobeat force-pushed the deps-ethereumjs-6 branch from d12a053 to 111a548 Compare October 23, 2024 10:38

legobeat marked this pull request as ready for review October 23, 2024 10:41

legobeat requested review from a team as code owners October 23, 2024 10:41

legobeat commented Oct 23, 2024

View reviewed changes

yarn.lock Outdated Show resolved Hide resolved

legobeat force-pushed the deps-ethereumjs-6 branch from 111a548 to b708bac Compare October 23, 2024 10:46

legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 23, 2024

legobeat marked this pull request as draft October 23, 2024 10:52

legobeat force-pushed the deps-ethereumjs-6 branch 5 times, most recently from 6256e6b to 33737d5 Compare October 23, 2024 13:27

legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 23, 2024

legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 29, 2024

This comment was marked as outdated.

Sign in to view

legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 29, 2024

legobeat mentioned this pull request Oct 29, 2024

fix: migrate from deprecated legacy packages #11968

Draft

12 tasks

legobeat force-pushed the deps-ethereumjs-6 branch from 1500bff to 3c7c575 Compare October 30, 2024 00:08

legobeat added 8 commits October 30, 2024 09:33

fix(deps): unpin [email protected],x [email protected]

3a819ce

fix: add package @types/bn.js

19870ab

fix: validateTokenAmount fix

359777b

lint:fix

63033b2

chore: remove redundant depcheckrc entry

deca6c9

chore: rename BN to BN4

c0cb793

fix(stake): import BN.js directly instead of through ethereumjs-util

d2f0719

legobeat force-pushed the deps-ethereumjs-6 branch from 3c7c575 to d2f0719 Compare October 30, 2024 00:33

legobeat requested a review from georgeweiler October 30, 2024 01:09

legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 30, 2024

matthewwalsh0 approved these changes Oct 30, 2024

View reviewed changes

pedronfigueiredo approved these changes Oct 30, 2024

View reviewed changes

Gudahtt mentioned this pull request Nov 1, 2024

feat(controller-utils): support bn.js v4 input to BN functions (re-introduces #4844) MetaMask/core#4886

Open

4 tasks

legobeat mentioned this pull request Nov 5, 2024

intToHex util produces invalid Quantities MetaMask/eth-json-rpc-filters#70

Open

NicolasMassart self-assigned this Dec 3, 2024

NicholasEllul removed the request for review from a team December 17, 2024 14:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(deps): unpin [email protected],x [email protected] #11972

fix(deps): unpin [email protected],x [email protected] #11972

legobeat commented Oct 23, 2024 •

edited

Loading

github-actions bot commented Oct 23, 2024

This comment was marked as outdated.

socket-security bot commented Oct 23, 2024 •

edited

Loading

This comment was marked as outdated.

github-actions bot commented Oct 23, 2024 •

edited by metamaskbot

Loading

This comment was marked as outdated.

github-actions bot commented Oct 29, 2024 •

edited by metamaskbot

Loading

sonarqubecloud bot commented Oct 30, 2024

github-actions bot commented Oct 30, 2024 •

edited by metamaskbot

Loading

fix(deps): unpin [email protected],x [email protected] #11972

Are you sure you want to change the base?

fix(deps): unpin [email protected],x [email protected] #11972

Conversation

legobeat commented Oct 23, 2024 • edited Loading

Description

Related issues

Blocking

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Oct 23, 2024

This comment was marked as outdated.

socket-security bot commented Oct 23, 2024 • edited Loading

This comment was marked as outdated.

github-actions bot commented Oct 23, 2024 • edited by metamaskbot Loading

Bitrise

This comment was marked as outdated.

github-actions bot commented Oct 29, 2024 • edited by metamaskbot Loading

Bitrise

sonarqubecloud bot commented Oct 30, 2024

Quality Gate passed

github-actions bot commented Oct 30, 2024 • edited by metamaskbot Loading

Bitrise

legobeat commented Oct 23, 2024 •

edited

Loading

socket-security bot commented Oct 23, 2024 •

edited

Loading

github-actions bot commented Oct 23, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 29, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 30, 2024 •

edited by metamaskbot

Loading