Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detox: Request token flow #1235

Merged
merged 3 commits into from
Dec 10, 2019
Merged

Detox: Request token flow #1235

merged 3 commits into from
Dec 10, 2019

Conversation

ibrahimtaveras00
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 commented Dec 4, 2019

This PR provides test coverage for Requesting a token

Seen here = http://recordit.co/H5KREZwRsD

Flow:

  • go to receive
  • tap on request
  • tap on ETH from top picks
  • search contract address for SAI and make sure SAI is in the results
  • search DAI
  • enter in value and submit
  • check QR code
  • close view

In addition to the test, this PR fixes a crash when writing text then pushing enter to submit in the search assets text input field

@ibrahimtaveras00 ibrahimtaveras00 added this to the v1 milestone Dec 4, 2019
@ibrahimtaveras00 ibrahimtaveras00 self-assigned this Dec 4, 2019
Copy link
Contributor

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibrahimtaveras00 ibrahimtaveras00 merged commit 54bfa87 into develop Dec 10, 2019
@ibrahimtaveras00 ibrahimtaveras00 deleted the detox-request-flow branch December 10, 2019 19:25
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* added test coverage for request flow

* Fixed crash when submitting search text by hitting enter

* added more tests for searching via contract address or text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants