Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(3800): settings drawer redesign #12801

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Dec 19, 2024

Description

This PR is part of a series of updates in preparation for the settings redesign. It updates the SettingsDrawer component to reflect the new UI design system, currently hidden behind the feature flag MM_SETTINGS_REDESIGN_ENABLE. This is the Figma Design for reference

Key Changes

  • Updated SettingsDrawer component with new design tokens
  • Added feature flag MM_SETTINGS_REDESIGN_ENABLE to toggle between old and new designs
  • Implemented new text variants for titles and descriptions
  • Added support for icons in the redesigned version
  • Updated styling to match new design specifications
  • Added comprehensive test coverage for both versions
  • Added Storybook stories to showcase component variations

Related issues

Fixes: #3800

Manual testing steps

  1. Goto settings with the feature flag off, observe there are no changes
  2. To view the settings component update, run MM_SETTINGS_REDESIGN_ENABLE=true yarn start, observe the new designs

Screenshots/Recordings

Feature Flag Off Feature Flag on
before after

Example of the new component in use (NOT THE REAL DESIGNS. Just showcasing what the component can do now)
example

Story (Feature Flag Off)

stories

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise settings-redesign labels Dec 20, 2024
@vinnyhoward vinnyhoward marked this pull request as ready for review December 20, 2024 00:31
@vinnyhoward vinnyhoward requested a review from a team as a code owner December 20, 2024 00:31
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: d1ccd51
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4e59ec3b-cf96-473b-8f76-01e322be340d

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 20, 2024
Copy link
Contributor

github-actions bot commented Dec 20, 2024

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: f7d909e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c93c5178-8e86-4758-bc9f-94b4f37ac978

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 20, 2024
@vinnyhoward vinnyhoward requested a review from a team as a code owner December 20, 2024 17:56
@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 20, 2024
Copy link
Contributor

github-actions bot commented Dec 20, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9ce9408
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c10ad961-f0c3-4ad8-aa98-79cb3bf9f8ef

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 20, 2024
Copy link
Contributor

github-actions bot commented Dec 20, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: de9d2dd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4b49af2d-4e5b-4443-8ab6-2ad7e24097b1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 20, 2024
@vinnyhoward vinnyhoward removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 20, 2024
@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5c99484
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3913b047-1dc9-4fc3-9b1e-739aaf70e32f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinnyhoward vinnyhoward added team-design-system All issues relating to design system in Mobile Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 6, 2025
@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e3ea4e9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9e9fad72-4b19-4464-98b6-1da5268a820c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 9, 2025
@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 10, 2025
Copy link
Contributor

github-actions bot commented Jan 10, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 81cf5a6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1c92abbf-42ca-49bc-92cb-3905fbebdb46

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 13, 2025
Copy link
Contributor

github-actions bot commented Jan 13, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 54cf116
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5f96963c-429d-488c-b9d3-2a82e40c942e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 15, 2025
Copy link
Contributor

github-actions bot commented Jan 15, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 91215f7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8e78aed7-01f8-4a1b-8c68-d80d30225499

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise settings-redesign team-design-system All issues relating to design system in Mobile team-wallet-ux
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

2 participants